Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add_output helper method on Blueprints #611

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Add add_output helper method on Blueprints #611

merged 1 commit into from
Jun 25, 2018

Conversation

phobologic
Copy link
Member

Got sick of constantly typing Output("Blah", Value="foo") and figured
we could make this easier.

Got sick of constantly typing `Output("Blah", Value="foo")` and figured
we could make this easier.
Copy link
Member

@russellballestrini russellballestrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composition is awesome.

@russellballestrini
Copy link
Member

russellballestrini commented Jun 25, 2018

@phobologic do you think we should do some verification of the name value so that we check if it is safe?

  • Alpha numeric only

@phobologic
Copy link
Member Author

My thought was to let troposphere do the validation, which it should already be doing in theory. That way if the rules change, and troposphere changes to match them, we get the benefits immediately.

@phobologic phobologic merged commit 6e29488 into master Jun 25, 2018
@phobologic phobologic deleted the add_output branch June 25, 2018 16:39
@phobologic phobologic added this to the 1.4 milestone Jul 1, 2018
phrohdoh pushed a commit to phrohdoh/stacker that referenced this pull request Dec 18, 2018
Got sick of constantly typing `Output("Blah", Value="foo")` and figured
we could make this easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants